Ensure ContentSettingsStore::RegisterExtension is called for components #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/brave/brave/issues/81
Note for reviewing that the added call to
extension_prefs_->OnExtensionInstalled
is always called right away inAddNewOrUpdatedExtension
but forAddExtension
it is never called:This seem to only be needed for
AddComponentExtension
and not extensions because the extensions are always loaded before the default components are added.Let me know if you can think of a better way to fix this. I had trouble finding a cleaner way.